[PATCH 1/4] Git.pm: Allow command_close_bidi_pipe() to be called as method
- From
- Michal Nazarewicz <mpn@google.com>
- Date
- Feb 6, 2013, 20:47 UTC
- Message-ID
- <01fceaac7a7d961cc7e0355b9c3175e0ba68cd0f.1360183427.git.mina86@mina86.com>
- In-Reply-To
- <cover.1360183427.git.mina86@mina86.com>
From: Michal Nazarewicz <mina86@mina86.com>
The documentation of command_close_bidi_pipe() claims that it can be called as a method, but it does not check whether the first argument is $self or not assuming the latter. Using _maybe_self() fixes this.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com> --- perl/Git.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/perl/Git.pm b/perl/Git.pm index 931047c..bbb753a 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -430,7 +430,7 @@ have more complicated structure. sub command_close_bidi_pipe { local $?; - my ($pid, $in, $out, $ctx) = @_; + my ($self, $pid, $in, $out, $ctx) = _maybe_self(@_); foreach my $fh ($in, $out) { unless (close $fh) { if ($!) {
-- 1.8.1.2.549.g4fa355e