git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 01/11] t6301: for-each-ref tests for ref-filter APIs

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 14, 2015, 08:12 UTC
Message-ID
<vpqvbeqd7y5.fsf@anie.imag.fr>
In-Reply-To
<1434226706-3764-1-git-send-email-karthik.188@gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 8 quoted lines
> +test_expect_success 'setup some history and refs' '
> +	test_commit one &&
> +	test_commit two &&
> +	test_commit three &&
> +	git checkout -b side &&
> +	test_commit four &&
> +	git checkout master &&
> +	git update-ref refs/odd/spot master

I think you want more corner-cases here. For example, refs/headsfoo/master should not match refs/heads, and it's easy to write an incorrect implementation for this => test.

> +'
> +test_expect_success 'filtering by leading name' '
Blank line between tests please.
Show 7 quoted lines
> +	cat >expect <<-\EOF &&
> +	refs/heads/master
> +	refs/heads/side
> +	EOF
> +	git for-each-ref --format="%(refname)" refs/heads >actual &&
> +	test_cmp expect actual
> +'
Isn't this test redundant with the content of t6300-for-each-ref.sh?

At this point, you've done only internal refactoring, so you shouldn't need new tests (except to fix coverage holes in existing tests).

I guess you're adding this to build more tests on top, but the commit message should clarify this.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Karthik NayakNext: karthik nayak
Message 19 of 20 in “add options to for-each-ref”
  1. 00/11 add options to for-each-refkarthik nayak, Jun 13, 2015
  2. 01/11 t6301: for-each-ref tests for ref-filter APIsKarthik Nayak, Jun 13, 2015
  3. 02/11 tag: libify parse_opt_points_at()Karthik Nayak, Jun 13, 2015
  4. 03/11 ref-filter: implement '--points-at' optionKarthik Nayak, Jun 13, 2015
  5. 04/11 for-each-ref: add '--points-at' optionKarthik Nayak, Jun 13, 2015
  6. 05/11 ref-filter: add parse_opt_merge_filter()Karthik Nayak, Jun 13, 2015
  7. Christian CouderJun 14, 2015
  8. karthik nayakJun 14, 2015
  9. 06/11 ref-filter: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jun 13, 2015
  10. 07/11 for-each-ref: add '--merged' and '--no-merged' optionsKarthik Nayak, Jun 13, 2015
  11. 08/11 parse-option: rename parse_opt_with_commit()Karthik Nayak, Jun 13, 2015
  12. 09/11 parse-options.h: add macros for '--contains' optionKarthik Nayak, Jun 13, 2015
  13. Christian CouderJun 14, 2015
  14. karthik nayakJun 14, 2015
  15. Junio C HamanoJun 15, 2015
  16. karthik nayakJun 15, 2015
  17. 10/11 ref-filter: implement '--contains' optionKarthik Nayak, Jun 13, 2015
  18. 11/11 for-each-ref: add '--contains' optionKarthik Nayak, Jun 13, 2015
  19. Matthieu MoyJun 14, 2015
  20. karthik nayakJun 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.