git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 05/11] ref-filter: add parse_opt_merge_filter()

From
Christian Couder <christian.couder@gmail.com>
Date
Jun 14, 2015, 05:49 UTC
Message-ID
<CAP8UFD1Qw+ctvz_CbBoE-jb5_bC3jogAsTgp-mgkVBFG1y7SiQ@mail.gmail.com>
In-Reply-To
<1434226706-3764-5-git-send-email-karthik.188@gmail.com>
On Sat, Jun 13, 2015 at 10:18 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
Show 20 quoted lines
>
> diff --git a/ref-filter.h b/ref-filter.h
> index c2856b8..799e118 100644
> --- a/ref-filter.h
> +++ b/ref-filter.h
> @@ -50,6 +50,18 @@ struct ref_filter_cbdata {
>         struct ref_filter *filter;
>  };
>
> +/*  Macros for checking --merged and --no-merged options */
> +#define OPT_NO_MERGED(filter, h) \
> +       { OPTION_CALLBACK, 0, "no-merged", (filter), N_("commit"), (h), \
> +         PARSE_OPT_LASTARG_DEFAULT | PARSE_OPT_NONEG, \
> +         parse_opt_merge_filter, (intptr_t) "HEAD" \
> +       }
> +#define OPT_MERGED(filter, h) \
> +       { OPTION_CALLBACK, 0, "merged", (filter), N_("commit"), (h), \
> +         PARSE_OPT_LASTARG_DEFAULT | PARSE_OPT_NONEG, \
> +         parse_opt_merge_filter, (intptr_t) "HEAD" \
> +       }
Could you reduce the redundancy in these 2 macros?
Previous: Karthik NayakNext: karthik nayak
Message 7 of 20 in “add options to for-each-ref”
  1. 00/11 add options to for-each-refkarthik nayak, Jun 13, 2015
  2. 01/11 t6301: for-each-ref tests for ref-filter APIsKarthik Nayak, Jun 13, 2015
  3. 02/11 tag: libify parse_opt_points_at()Karthik Nayak, Jun 13, 2015
  4. 03/11 ref-filter: implement '--points-at' optionKarthik Nayak, Jun 13, 2015
  5. 04/11 for-each-ref: add '--points-at' optionKarthik Nayak, Jun 13, 2015
  6. 05/11 ref-filter: add parse_opt_merge_filter()Karthik Nayak, Jun 13, 2015
  7. Christian CouderJun 14, 2015
  8. karthik nayakJun 14, 2015
  9. 06/11 ref-filter: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jun 13, 2015
  10. 07/11 for-each-ref: add '--merged' and '--no-merged' optionsKarthik Nayak, Jun 13, 2015
  11. 08/11 parse-option: rename parse_opt_with_commit()Karthik Nayak, Jun 13, 2015
  12. 09/11 parse-options.h: add macros for '--contains' optionKarthik Nayak, Jun 13, 2015
  13. Christian CouderJun 14, 2015
  14. karthik nayakJun 14, 2015
  15. Junio C HamanoJun 15, 2015
  16. karthik nayakJun 15, 2015
  17. 10/11 ref-filter: implement '--contains' optionKarthik Nayak, Jun 13, 2015
  18. 11/11 for-each-ref: add '--contains' optionKarthik Nayak, Jun 13, 2015
  19. Matthieu MoyJun 14, 2015
  20. karthik nayakJun 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.