Re: [PATCH v13 00/12] port tag.c to use ref-filter APIs
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Aug 24, 2015, 15:16 UTC
- Message-ID
- <vpqvbc490oh.fsf@anie.imag.fr>
- In-Reply-To
- <CAOLa=ZQx_eWdq5cLskAT_c1OjZ-7DwWwZTC9S=ZafEDYHFGncg@mail.gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 23 quoted lines
> On Mon, Aug 24, 2015 at 1:30 AM, Matthieu Moy > <Matthieu.Moy@grenoble-inp.fr> wrote: >> Karthik Nayak <karthik.188@gmail.com> writes: >> >>> diff --git a/Documentation/git-for-each-ref.txt b/Documentation/git-for-each-ref.txt >>> index 1997657..06d468e 100644 >>> --- a/Documentation/git-for-each-ref.txt >>> +++ b/Documentation/git-for-each-ref.txt >>> @@ -133,7 +133,8 @@ align:: >>> `<position>` is either left, right or middle and `<width>` is >>> the total length of the content with alignment. If the >>> contents length is more than the width then no alignment is >>> - performed. >>> + performed. If used with '--quote' everything in between %(align:..) >>> + and %(end) is quoted. >> >> There's no --quote, there are --shell, --python, ... (well, actually, I >> would have prefered to have a single --quote=language option, but that's >> not how it is now). > > That'd be easy to implement, but I didn't because `git tag -l` is > human readable and > I didn't see the necessity for having something like `--<quote_type>` here.
Agreed: tag does not have --shell, --python & so and does not need it.
But that's not my point: you write "if used with '--quote'", and the option name is not --quote. It should be "if used with `--shell`, `--python`, ... then everything ...".
-- Matthieu Moy http://www-verimag.imag.fr/~moy/