Re: [PATCH v13 11/12] tag.c: implement '--format' option
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Aug 24, 2015, 15:07 UTC
- Message-ID
- <CAOLa=ZR4LJSou5QqmZJm1M49tD74t4Besb64F+XOHefjnxo7xw@mail.gmail.com>
- In-Reply-To
- <vpq37z9lqwp.fsf@anie.imag.fr>
On Mon, Aug 24, 2015 at 1:26 AM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
Show 24 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes: > >> --- a/Documentation/git-tag.txt >> +++ b/Documentation/git-tag.txt >> @@ -13,7 +13,8 @@ SYNOPSIS >> <tagname> [<commit> | <object>] >> 'git tag' -d <tagname>... >> 'git tag' [-n[<num>]] -l [--contains <commit>] [--points-at <object>] >> - [--column[=<options>] | --no-column] [--create-reflog] [--sort=<key>] [<pattern>...] >> + [--column[=<options>] | --no-column] [--create-reflog] [--sort=<key>] >> + [--format=<format>] [<pattern>...] >> 'git tag' -v <tagname>... >> >> DESCRIPTION >> @@ -158,6 +159,11 @@ This option is only applicable when listing tags without annotation lines. >> The object that the new tag will refer to, usually a commit. >> Defaults to HEAD. >> >> +<format>:: > > Shouldn't this be --format <format>, not just <format>? We usually use > the named argument in the SYNOPSIS for positional arguments, but not for > arguments following an option. >
This is how it was in for-each-ref Documentation, hence to keep it similar I just put <format>.
-- Regards, Karthik Nayak