Re: [PATCH v4 3/6] rewrite git_config() to use the config-set API

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jul 29, 2014, 12:38 UTC
Message-ID: <vpqsilk8hn8.fsf@anie.imag.fr>
In-Reply-To: <53D786F9.9070002@gmail.com>

Tanay Abhra <tanayabh@gmail.com> writes:

Show 17 quoted lines

>> diff --git a/t/t4055-diff-context.sh b/t/t4055-diff-context.sh
>> index cd04543..741e080 100755
>> --- a/t/t4055-diff-context.sh
>> +++ b/t/t4055-diff-context.sh
>> @@ -79,7 +79,7 @@ test_expect_success 'non-integer config parsing' '
>>  test_expect_success 'negative integer config parsing' '
>>  	git config diff.context -1 &&
>>  	test_must_fail git diff 2>output &&
>> -	test_i18ngrep "bad config file" output
>> +	test_i18ngrep "bad config variable" output
>>  '
>>
>>  test_expect_success '-U0 is valid, so is diff.context=0' '
>>
>
> This was a minor fixup with only a changed word, so I didn't flip it and
> fix after in the series as you said yesterday. Dunno if it's alright.

You did right. It's not a new test, but an existing one that needs update together with your code update.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/