git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 3/6] rewrite git_config() to use the config-set API

From
Tanay Abhra <tanayabh@gmail.com>
Date
Jul 29, 2014, 11:35 UTC
Message-ID
<53D786F9.9070002@gmail.com>
In-Reply-To
<1406633302-23144-4-git-send-email-tanayabh@gmail.com>
Show 14 quoted lines
> diff --git a/t/t4055-diff-context.sh b/t/t4055-diff-context.sh
> index cd04543..741e080 100755
> --- a/t/t4055-diff-context.sh
> +++ b/t/t4055-diff-context.sh
> @@ -79,7 +79,7 @@ test_expect_success 'non-integer config parsing' '
>  test_expect_success 'negative integer config parsing' '
>  	git config diff.context -1 &&
>  	test_must_fail git diff 2>output &&
> -	test_i18ngrep "bad config file" output
> +	test_i18ngrep "bad config variable" output
>  '
>
>  test_expect_success '-U0 is valid, so is diff.context=0' '
>

This was a minor fixup with only a changed word, so I didn't flip it and fix after in the series as you said yesterday. Dunno if it's alright.

Previous: Tanay AbhraNext: Matthieu Moy
Message 5 of 13 in “Rewrite `git_config()` using config-set API”
  1. 0/6 Rewrite `git_config()` using config-set APITanay Abhra, Jul 29, 2014
  2. 1/6 config.c: fix accuracy of line number in errorsTanay Abhra, Jul 29, 2014
  3. 2/6 add line number and file name info to `config_set`Tanay Abhra, Jul 29, 2014
  4. 3/6 rewrite git_config() to use the config-set APITanay Abhra, Jul 29, 2014
  5. Tanay AbhraJul 29, 2014
  6. Matthieu MoyJul 29, 2014
  7. Matthieu MoyJul 29, 2014
  8. Tanay AbhraJul 29, 2014
  9. Matthieu MoyJul 29, 2014
  10. Tanay AbhraJul 29, 2014
  11. 4/6 add a test for semantic errors in config filesTanay Abhra, Jul 29, 2014
  12. 5/6 config: add `git_die_config()` to the config-set APITanay Abhra, Jul 29, 2014
  13. 6/6 add tests for `git_config_get_string_const()`Tanay Abhra, Jul 29, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.