Re: git should not use a default user.email config value
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Aug 14, 2013, 14:07 UTC
- Message-ID
- <vpqr4dwl61b.fsf@anie.imag.fr>
- In-Reply-To
- <CAPc5daWqzTkMFkecrAjMCmxwZZrgUtB-FVKrjsmfvpgwPgF8AA@mail.gmail.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 29 quoted lines
> On Wed, Aug 14, 2013 at 1:37 AM, Matthieu Moy > <Matthieu.Moy@grenoble-inp.fr> wrote: >> >> Jeff King <peff@peff.net> writes: >> >> > This whole discussion is basically implementing conditional config. >> > [...] The problem is that it would be tricky to do in a >> > backwards-compatible way. >> >> That could be done with "conditional comments" like >> >> # if <some-condition> then >> [core] >> pager = less >> # endif >> >> That's rather ugly, and the implementation would be even more ugly, but >> backward-compatible. > > > I highly doubt that you would want to be "backward compatible" in this > case, though. > The section of the configuration you are enclosing the new if/endif > syntax may be > understood only by newer Git (e.g. imagine core.pager is still > bool-only today), and > older Git that do not understand if/endif syntax will happily read > that section and > choke on it, no?
Indeed. That would be more
# if <some-condition> then # [core] # pager = less # endif
which is even more ugly ;-).
-- Matthieu Moy http://www-verimag.imag.fr/~moy/