Re: git should not use a default user.email config value

From: Jeff King <peff@peff.net>
Date: Aug 13, 2013, 11:46 UTC
Message-ID: <20130813114635.GA16506@sigill.intra.peff.net>
In-Reply-To: <CAH5451=WKXUNzovXquFii=EdkeQXJEQ96_CRRebgQW6ow_19VA@mail.gmail.com>

On Tue, Aug 13, 2013 at 09:05:40PM +1000, Andrew Ardill wrote:

Show 8 quoted lines

> I applied this on top of latest next (1da3ebde8999d07), and it worked
> perfectly for my use case.
> 
> For what it's worth, it also passed the test suite!
> 
> Would be great to see this, or something on the same theme, get into
> master. I'd be happy to review patches/write tests/write documentation
> if needed.

Like I said, I do not have a particular use for it, but I don't think it would hurt anybody who does not use it. If you want to polish it up into a real patch with docs and tests, I don't mind.

The only downside I can think of is that we might want to use the subsection in "include.SUBSECTION.*" for some other limiting conditions (e.g., "only include this config when running version >= X.Y", or even "include only when environment variable FOO is true").

I guess we could do something like:

  [include "repo:...your regex here..."]
    path = .gitconfig-only-for-some-repos
  [include "env:USE_MY_MAGIC_CONFIG"]
    path = .gitconfig-only-when-magic-env-set

Adding the "repo:" prefix for this repo-dir matching is pretty trivial. Adding a similar env-matching is only slightly less trivial; but does anybody actually want it?

-Peff