Re: [PATCH 3/3] git-am: add am.threeWay config variable
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- May 28, 2015, 19:20 UTC
- Message-ID
- <vpqpp5kpl09.fsf@anie.imag.fr>
- In-Reply-To
- <xmqqy4k8h9f8.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 22 quoted lines
>> I've noticed that in the block above that initializes all the variables, >> >> sign= utf8=t keep= keepcr= skip= interactive= resolved= rebasing= abort= >> messageid= resolvemsg= resume= scissors= no_inbody_headers= >> git_apply_opt= >> committer_date_is_author_date= >> ignore_date= >> allow_rerere_autoupdate= >> gpg_sign_opt= >> >> threeway is not initialized at all, and thus I think running >> "threeway=t git am blah" will affect the behavior of git-am. > > Correct. I overlooked this when I originally did threeway. Perhaps > a preparatory bugfix patch is warranted before this one. > >> Also, I noticed that we do not check for --no-interactive, >> --no-signoff, --no-keep, --no-whitespace, etc. > > Even though adding support for them would not hurt, lack of these > are OK, as long as we do not have configuration variables to tweak > their defaults.
I wouldn't worry about these issues, as the port to C will make them disappear anyway.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/