Re: [PATCH 1/3] t4150-am: refactor and clean common setup

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 28, 2015, 19:18 UTC
Message-ID: <CAPig+cTdVZKrGM+8eSopCkUYxK08WB3ZriFOcbd+8Zkf2Y27nA@mail.gmail.com>
In-Reply-To: <CAPig+cQ_PrY8=-iP-FJm_HZ+XKOVoc4NfDu6rtuBj8zfM5oG+w@mail.gmail.com>

On Thu, May 28, 2015 at 3:09 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:

> On Tue, May 26, 2015 at 5:32 PM, Remi Lespinet
> <remi.lespinet@ensimag.grenoble-inp.fr> wrote:
>> +setup_temporary_branch () {
>> +       tmp_name=${2-"temporary"}

I forgot to mention the broken &&-chain here. Although the missing && doesn't actively hurt the function today, someone may someday insert code above the 'tmp_name=' line without noticing the lack of &&, and the test won't notice a failure in that newly added code. Thus, it's better to keep the &&-chain intact throughout.

Show 5 quoted lines

>> +       git reset --hard &&
>> +       rm -fr .git/rebase-apply &&
>> +       test_when_finished "git checkout $1 && git branch -D $tmp_name" &&
>> +       git checkout -b "$tmp_name" "$1"
>> +}