Re: [PATCH] rebase -i: remove undocumented '--verify' flag

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Nov 22, 2010, 12:53 UTC
Message-ID: <vpqoc9hsemy.fsf@bauges.imag.fr>
In-Reply-To: <1290408504-14639-1-git-send-email-martin.von.zweigbergk@gmail.com>

Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:

> Remove the undocumented and unused '--verify' flag from interactive
> rebase.

I don't think this change is good. If a command has a --no-whatever flag, one expects the --whatever flag to exist too, even if it's a no-op.

>  	--no-verify)
>  		OK_TO_SKIP_PRE_REBASE=yes
>  		;;

--no-verify exists, so

> -	--verify)
> -		;;

--verify exists too.

I think a better change would be to add a comment like

--verify)
	# no-op, exists because --no-verify exists too.
	;;

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/