Re: [PATCH] rebase -i: remove undocumented '--verify' flag

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Nov 22, 2010, 13:29 UTC
Message-ID: <vpq8w0lqyf7.fsf@bauges.imag.fr>
In-Reply-To: <201011221414.15982.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

Show 20 quoted lines

> Matthieu Moy wrote:
>> Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:
>> 
>> > Remove the undocumented and unused '--verify' flag from interactive
>> > rebase.
>> 
>> I don't think this change is good. If a command has a --no-whatever
>> flag, one expects the --whatever flag to exist too, even if it's a
>> no-op.
> [...]
>> I think a better change would be to add a comment like
>> 
>> --verify)
>> 	# no-op, exists because --no-verify exists too.
>
> Shouldn't that be
>
>   OK_TO_SKIP_PRE_REBASE=
>
> instead, so that it undoes the effect of an earlier --no-verify?

Yes, right. Useful when an alias contains --no-whatever in particular.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/