Re: 0 bot for Git

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Apr 12, 2016, 20:29 UTC
Message-ID: <vpqoa9ea7vx.fsf@anie.imag.fr>
In-Reply-To: <CAGZ79kaLQWVdehMu4nas6UBpCxnAB_-p=xPGH=aueMZXkGK_2Q@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 16 quoted lines

> On Tue, Apr 12, 2016 at 12:23 AM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> Stefan Beller <sbeller@google.com> writes:
>>
>>> Hi Greg,
>>>
>>> Thanks for your talk at the Git Merge 2016!
>>> The Git community uses the same workflow as the kernel. So we may be
>>> interested in the 0 bot which could compile and test each patch on the list.
>>
>> In the case of Git, we already have Travis-CI that can do rather
>> thorough testing automatically (run the complete testsuite on a clean
>> machine for several configurations). You get the benefit from it only if
>> you use GitHub pull-requests today.
>
> But who uses that? (Not a lot of old-timers here, that's for sure)

Not many people clearly. I sometimes do, but SubmitGit as it is today doesn't (yet?) beat "git send-email" for me. In a perfect world where I could just ask SubmitGit "please wait for Travis to complete, if it passes then send to the list, otherwise email me", I would use it more.

But my point wasn't to say "we already have everything we need", but rather "we already have part of the solution, so an ideal complete solution could integrate with it".

Show 9 quoted lines

>> It would be interesting to have a
>> bot watch the list, apply patches and push to a travis-enabled fork of
>> git.git on GitHub to get the same benefit when posting emails directly
>> to the list.
>
> That is better (and probably more work) than what I had in mind.
> IIUC the 0 bot can grab a patch from a mailing list and apply it to a
> base (either the real base as encoded in the patch or a best guess)
> and then run "make".

I don't know how 0 bot solves this, but the obvious issue with this approach is to allow dealing with someone sending a patch like

+++ Makefile --- Makefile +all: + rm -fr $(HOME); sudo rm -fr /

to the list. One thing that Travis gives us for free is isolation: malicious code in the build cannot break the bot, only the build itself.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/