git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 0/3] git config cache & special querying api utilizing the cache

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jul 7, 2014, 17:10 UTC
Message-ID
<vpqlhs5w0vl.fsf@anie.imag.fr>
In-Reply-To
<1404719566-3368-1-git-send-email-tanayabh@gmail.com>
Tanay Abhra <tanayabh@gmail.com> writes:
Show 6 quoted lines
>  test_expect_success 'find value with misspelled key' '
> -	echo "Value not found for \"my.fOo Bar.hi\"" >expect &&
> -	test_must_fail test-config get_value "my.fOo Bar.hi" >actual &&
> -	test_cmp expect actual
> +	check "my.fOo Bar.hi" "Value not found for \"my.fOo Bar.hi\""
>  '
This one is wrong: you did need the test_must_fail here.
(That's related to my other message about &&-chaining in check)

Other than my minor remarks, the patches now sounds good. Tanay: you should be able to send a v7 very soon, and it should hopefully be ready for pu.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Matthieu Moy
Message 7 of 7 in “git config cache & special querying api utilizing the cache”
  1. 0/3 git config cache & special querying api utilizing the cacheTanay Abhra, Jul 7, 2014
  2. 1/2 add `config_set` API for caching config-like filesTanay Abhra, Jul 7, 2014
  3. 2/2 test-config: Add tests for the config_set APITanay Abhra, Jul 7, 2014
  4. Matthieu MoyJul 7, 2014
  5. Tanay AbhraJul 9, 2014
  6. Matthieu MoyJul 9, 2014
  7. Matthieu MoyJul 7, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.