From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Mon, 07 Jul 2014 17:10:38 GMT
Subject: Re: [PATCH v6 0/3] git config cache & special querying api utilizing the cache
Message-ID: <vpqlhs5w0vl.fsf@anie.imag.fr>
In-Reply-To: <1404719566-3368-1-git-send-email-tanayabh@gmail.com>

Tanay Abhra <tanayabh@gmail.com> writes:

>  test_expect_success 'find value with misspelled key' '
> -	echo "Value not found for \"my.fOo Bar.hi\"" >expect &&
> -	test_must_fail test-config get_value "my.fOo Bar.hi" >actual &&
> -	test_cmp expect actual
> +	check "my.fOo Bar.hi" "Value not found for \"my.fOo Bar.hi\""
>  '

This one is wrong: you did need the test_must_fail here.

(That's related to my other message about &&-chaining in check)

Other than my minor remarks, the patches now sounds good. Tanay: you
should be able to send a v7 very soon, and it should hopefully be ready
for pu.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/