git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-remote-mediawiki: remove hardcoded version number in the test suite

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 13, 2013, 11:38 UTC
Message-ID
<vpqk3lytf4l.fsf@anie.imag.fr>
In-Reply-To
<1371123008-28068-1-git-send-email-benoit.person@ensimag.fr>
benoit.person@ensimag.fr writes:
> Updates the code to make it more easy to switch mediawiki version when
> testing. Before that, the version number was partly hardcoded, partly
> in a var.
This is obviously good.
> Maybe I should add a warning that the installation procedure may not work 
> in the future ? It seems to work for the range 1.19.X - 1.21.X though :) ?
> Should I also update the version number to the latest one (1.21.1) ?

This kind of remarks does not belong to the commit message, it should be below the --- (before the diffstat).

And yes, I think a comment saying "# Versions foo, bar and boz have been tested" or so would be welcome.

Thanks,
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: benoit.person@ensimag.fr
Message 2 of 2 in “git-remote-mediawiki: remove hardcoded version number in the test suite”
  1. git-remote-mediawiki: remove hardcoded version number in the test suitebenoit.person@ensimag.fr, Jun 13, 2013
  2. Matthieu MoyJun 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.