From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 13 Jun 2013 11:38:18 GMT
Subject: Re: [PATCH] git-remote-mediawiki: remove hardcoded version number in the test suite
Message-ID: <vpqk3lytf4l.fsf@anie.imag.fr>
In-Reply-To: <1371123008-28068-1-git-send-email-benoit.person@ensimag.fr>

benoit.person@ensimag.fr writes:

> Updates the code to make it more easy to switch mediawiki version when
> testing. Before that, the version number was partly hardcoded, partly
> in a var.

This is obviously good.

> Maybe I should add a warning that the installation procedure may not work 
> in the future ? It seems to work for the range 1.19.X - 1.21.X though :) ?
> Should I also update the version number to the latest one (1.21.1) ?

This kind of remarks does not belong to the commit message, it should be
below the --- (before the diffstat).

And yes, I think a comment saying "# Versions foo, bar and boz have been
tested" or so would be welcome.

Thanks,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/