Re: [PATCH] Do not decode url protocol.

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Humm, looking a bit closer ...

Pascal Obry <pascal@obry.net> writes:

This function is called from multiple places :

char *url_decode(const char *url)
{
	return url_decode_internal(&url, NULL);
}

char *url_decode_parameter_name(const char **query)
{
	return url_decode_internal(query, "&=");
}

char *url_decode_parameter_value(const char **query)
{
	return url_decode_internal(query, "&");
}

I don't think you want to avoid escaping until the first slash in url_decode_parameter_name and url_decode_parameter_value. I think you want to patch url_decode, not url_decode_internal.

Are you sure the URL contains a / at this point? That would be a user error if it doesn't, but has this been validated (with a clean error message if needed) earlier in the code?