Re: [PATCH] Do not decode url protocol.

From: Pascal Obry <pascal@obry.net>
Date: Jun 22, 2010, 11:46 UTC
Message-ID: <AANLkTilFfA4Gf4UK64b67O5ey-vwH7Yby8eH8ypFI8HX@mail.gmail.com>
In-Reply-To: <vpqiq5bb8rx.fsf@bauges.imag.fr>

Matthieu,

> Are you sure the URL contains a / at this point? That would be a user
> error if it doesn't, but has this been validated (with a clean error
> message if needed) earlier in the code?

Yes, all calls are either from http-backend.c (here we have a protocol specified, http://) or in connect.c where a test is done to make sure we have an url (and not a simple path):

	if (is_url(url_orig))
		url = url_decode(url_orig);
	else
		url = xstrdup(url_orig);

Pascal.

-- 
--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595