Re: [PATCH] git-commit: Reformat log messages provided on commandline
- From
Matthieu Moy <matthieu.moy@imag.fr>
- Date
- May 9, 2007, 15:32 UTC
- Message-ID
- <vpqfy66gght.fsf@bauges.imag.fr>
- In-Reply-To
- <20070509151148.GW4489@pasky.or.cz>
Petr Baudis <pasky@suse.cz> writes:
> Hmm, I don't really know if it's more evil to split an extra-long line > to two or keep it longer than the maximum sane width.
The evil already happened several times in git's repository ;-).
$ git log --all --pretty=oneline | grep \ ' ................................................................................' \ | wc -l 81 $
When I encounter such long line, I often just don't care, since my terminal or tool (gitk ...) is often more than 80 char. And in the cases I care, the fix is just to enlarge the window or to scroll (only people using a text-mode console would _really_ be disturbed).
With the other solution (breaking the line automatically), I have no easy fix. In gitk, I have the beginning of a sentence in the summary field, in a mailed patched, I have the sentence split between the Subject: header and the body.
(but we agree that both cases are evil. Perhaps just "ERROR: you're doing evil" would be better ...)
-- Matthieu