Re: [RFC/PATCH] push: deny policy to prevent pushes to unwanted remotes.
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Jun 21, 2016, 06:20 UTC
- Message-ID
- <vpqfus7jc59.fsf@anie.imag.fr>
- In-Reply-To
- <1599012395.707458.1466461517473.JavaMail.zimbra@ensimag.grenoble-inp.fr>
Antoine Queru <antoine.queru@ensimag.grenoble-inp.fr> writes:
Show 8 quoted lines
> However, in the last version, if we want to deny an website, > including all schemes, we can blacklist the url without the > scheme. For example, "pushBlacklist = github.com". By doing so, this > remote is not an url anymore, and it can't be differenced with a local > relative path. It's a problem because these two have a different > treatement. The choice we made to solve this is to force the user to > put the scheme "file://" before any local relative path. What do you > think ?
file:// URL can not be relative (well, you can invent a syntax where they are, but that would be weird).
I think you can just forbid relative path in whitelist/blacklist, hence consider that anything that is neither a full URL nor an absolute path is a protocol-less URL:
* http://github.com = github.com with HTTP protocol
* github.com = github.com with any protocol
* /path/to/file or file:///path/to/file = local path
-- Matthieu Moy http://www-verimag.imag.fr/~moy/