Re: [RFC/PATCH] push: deny policy to prevent pushes to unwanted remotes.

From: Antoine Queru <antoine.queru@ensimag.grenoble-inp.fr>
Date: Jun 20, 2016, 22:25 UTC
Message-ID: <1599012395.707458.1466461517473.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <3899461F-44B4-407F-ACCE-793E65486554@gmail.com>

Show 14 quoted lines

> 
> >> ...
> >> 
> > 
> > Hello Rémi, thanks you for your input ! I'll make the appropriate changes
> > and send a new version as soon as i can !
> 
> Hi Antoine,
> 
> do you have an updated version already or is this the one I should look at?
> http://article.gmane.org/gmane.comp.version-control.git/296445
> 
> Thanks,
> Lars

Hello Lars ! I'm actually in holidays, but I will try to send a new version by the end of the week, it's nearly done. The code has been refactored with what Matthieu and Remi told, so don't bother to read the last version.

However, in the last version, if we want to deny an website, including all schemes, we can blacklist the url without the scheme. For example, "pushBlacklist = github.com". By doing so, this remote is not an url anymore, and it can't be differenced with a local relative path. It's a problem because these two have a different treatement. The choice we made to solve this is to force the user to put the scheme "file://" before any local relative path. What do you think ?

Antoine