Re: [PATCH 2/3] Testing: XDG config files: Use "$HOME" and "$XDG_CONFIG_HOME" explicitly

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jul 17, 2012, 18:19 UTC
Message-ID: <vpqehoap7x7.fsf@bauges.imag.fr>
In-Reply-To: <e118f47351094d4fb45dd34bc08b9e9b-mfwitten@gmail.com>

Michael Witten <mfwitten@gmail.com> writes:

Show 10 quoted lines

> The tests in:
>
>   t/t1306-xdg-files.sh
>
> relied on brittle conventions:
>
>   * "$HOME" and "$XDG_CONFIG_HOME" having certain values.
>
>   * The testing commands having a certain current working
>     directory;

Other tests (t1305-config-include.sh at least) use the fact that the tests are ran in $HOME. I'm not sure if we want to change that.

About XDG_CONFIG_HOME, the tests were just assuming it was unset.

> +GIT_CONFIG_DIR=$XDG_CONFIG_HOME/git

As I said in my earlier message, I'd rather test the default value ($HOME/.config/git) than the particular case whe $XDG_CONFIG_HOME is set.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/