Re: [PATCH 1/3] Testing: XDG config files: Export a suitable `XDG_CONFIG_HOME' environment variable

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jul 17, 2012, 17:57 UTC
Message-ID: <20120717175740.GA14361@burratino>
In-Reply-To: <679ad82bd4604d1c903f3c2fff2a8cfb-mfwitten@gmail.com>

Hi,

Michael Witten wrote:

Show 9 quoted lines

> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -544,6 +544,9 @@ rm -fr "$test" || {
>  HOME="$TRASH_DIRECTORY"
>  export HOME
>  
> +XDG_CONFIG_HOME=$HOME/.config
> +export XDG_CONFIG_HOME
> +

I think this is a bad idea. The typical case is for XDG_CONFIG_HOME not to be set, and we need to make sure git works well in the typical case.

But the general idea seems sane --- how about

	unset VISUAL EMAIL LANGUAGE COLUMNS XDG_CONFIG_HOME $(perl -e '
		...