git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 4/7] rewrite git_config() to use the config-set API

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jul 31, 2014, 11:28 UTC
Message-ID
<vpqegx1ephk.fsf@anie.imag.fr>
In-Reply-To
<1406799857-28048-5-git-send-email-tanayabh@gmail.com>
Tanay Abhra <tanayabh@gmail.com> writes:
> +			if (!kv_info->linenr)
> +				die("unable to parse '%s' from command-line config", entry->key);
> +			else
> +				die("bad config variable '%s' at file line %d in %s",
Also two missing _("...") here.

Note that there are missing _("...") in config.c before your patch too. I'll send a patch to fix this regardless of your series.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Tanay AbhraNext: Tanay Abhra
Message 10 of 14 in “Rewrite `git_config()` using config-set API”
  1. 0/7 Rewrite `git_config()` using config-set APITanay Abhra, Jul 31, 2014
  2. 1/7 config.c: fix accuracy of line number in errorsTanay Abhra, Jul 31, 2014
  3. 2/7 add line number and file name info to `config_set`Tanay Abhra, Jul 31, 2014
  4. 3/7 change `git_config()` return value to voidTanay Abhra, Jul 31, 2014
  5. Matthieu MoyJul 31, 2014
  6. Matthieu MoyJul 31, 2014
  7. Tanay AbhraJul 31, 2014
  8. Matthieu MoyJul 31, 2014
  9. 4/7 rewrite git_config() to use the config-set APITanay Abhra, Jul 31, 2014
  10. Matthieu MoyJul 31, 2014
  11. 5/7 add a test for semantic errors in config filesTanay Abhra, Jul 31, 2014
  12. 6/7 config: add `git_die_config()` to the config-set APITanay Abhra, Jul 31, 2014
  13. Matthieu MoyJul 31, 2014
  14. 7/7 add tests for `git_config_get_string_const()`Tanay Abhra, Jul 31, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.