Re: [PATCH v5 3/7] change `git_config()` return value to void

From: Tanay Abhra <tanayabh@gmail.com>
Date: Jul 31, 2014, 11:52 UTC
Message-ID: <53DA2E02.4000408@gmail.com>
In-Reply-To: <vpqoaw5epsa.fsf@anie.imag.fr>

On 7/31/2014 4:52 PM, Matthieu Moy wrote:

Show 6 quoted lines

> Tanay Abhra <tanayabh@gmail.com> writes:
> 
>> Signed-off-by: Tanay Abhra <tanayabh@gmail.com>
> 
> I think I deserve a bit of credit here ;-).
>

Yes, but to show credit would I have to write "from you" or "signed-off-by"? :)

Show 21 quoted lines

>>  {
>> -	return git_config_with_options(fn, data, NULL, 1);
>> +	if (git_config_with_options(fn, data, NULL, 1) < 0)
>> +		/*
>> +		 * git_config_with_options() normally returns only
>> +		 * positive values, as most errors are fatal, and
>> +		 * non-fatal potential errors are guarded by "if"
>> +		 * statements that are entered only when no error is
>> +		 * possible.
>> +		 *
>> +		 * If we ever encounter a non-fatal error, it means
>> +		 * something went really wrong and we should stop
>> +		 * immediately.
>> +		 */
>> +		die("Unknown error occured while reading the configuration files");
>>  }
> 
> My bad, but this should be die(_("..."));, so that the message can be
> translated. Not really serious since it's not really meant to be seen by
> the user, though.
>

Noted. Though there are not many cases till I have read where error messages are marked for translation.