git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/4] log --count: added test

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jul 3, 2015, 09:16 UTC
Message-ID
<vpqegkp38jg.fsf@anie.imag.fr>
In-Reply-To
<CAKDoJU7MT5PkoPKaF=NYne0sgNfGC6q+y7+57L0135dgxKThgw@mail.gmail.com>
Lawrence Siebert <lawrencesiebert@gmail.com> writes:
> Ok, I'll fix that.

(Note: this is a typical example of why we don't top-post here. I made several remarks and I can't know what "that" refers to)

(Meta-note: don't take the note as agressive, I know that top-posting is the norm in many other places, I'm just giving you a glimpse of the local culture ;-) ).

> If it's acceptable practice, I'll just squash everything I do on this
> feature and it's tests into one commit with a more detailed comment,
> and send the patch for that.

I think at least two patches are better: your PATCH 1 is a typical preparation step, best reviewed alone in its own patch.

Splitting history into several patches is good, but each patch should correspond to one logical step. Splitting code Vs doc Vs tests is usually not the right way.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Lawrence SiebertNext: Matthieu Moy
Message 13 of 17 in “git log --count”
  1. 0/4 git log --countLawrence Siebert, Jul 2, 2015
  2. 1/4 list-object: add get_commit_count functionLawrence Siebert, Jul 2, 2015
  3. Matthieu MoyJul 3, 2015
  4. Lawrence SiebertJul 3, 2015
  5. Matthieu MoyJul 3, 2015
  6. 2/4 log: add --count option to git logLawrence Siebert, Jul 2, 2015
  7. Matthieu MoyJul 3, 2015
  8. Lawrence SiebertJul 3, 2015
  9. Matthieu MoyJul 3, 2015
  10. 3/4 log --count: added testLawrence Siebert, Jul 2, 2015
  11. Matthieu MoyJul 3, 2015
  12. Lawrence SiebertJul 3, 2015
  13. Matthieu MoyJul 3, 2015
  14. Matthieu MoyJul 3, 2015
  15. Junio C HamanoJul 4, 2015
  16. Junio C HamanoJul 4, 2015
  17. 4/4 git-log: update man documentation for --countLawrence Siebert, Jul 2, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.