Re: [RFC v2] git-multimail: a replacement for post-receive-email

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Feb 25, 2013, 09:54 UTC
Message-ID: <vpqd2vok9bv.fsf@grenoble-inp.fr>
In-Reply-To: <5129A5B3.7020807@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

Show 23 quoted lines

> On 02/20/2013 01:28 PM, Matthieu Moy wrote:
>> Michael Haggerty <mhagger@alum.mit.edu> writes:
>>> A while ago, I submitted an RFC for adding a new email notification
>>> script to "contrib" [...]
>> 
>> We've discussed offline with Michael, a few patches have been merged,
>> and there are still a few pending pull requests. I liked the script
>> already, but it's getting even cooler ;-).
>> 
>> A few more random thoughts (not on my personal todo-list):
>> 
>> * It may make sense to add the short sha1 of the new reference in email
>>   titles (branch foo updated -> branch foo updated to $sha1), so that
>>   gmail users do not get a single huge thread "branch foo updated".
>> 
>>   (Yes, I do know about the Reference field, but gmail uses Subject: for
>>   threading).
>> [...]
>
> I just implemented this in branch sha1s-in-subject [1].  Please let me
> know if this works for you then I'll merge it to master.  (It depends on
> the header-handling branch, which also includes your patch for non-ASCII
> header fields.)

Works for me. One minor knit: you've included 10-characters sha1s (this comes from

        self.short = read_output(['git', 'rev-parse', '--short=10', sha1])

), I'd find it better with shorter sha1s. In the case of branch update, if the branch name is a bit long, it could be nice to save a few characters.

Why not just say "git rev-parse --short", without argument? This way, the default is used, ie. AFAICT it uses 7 characters by default, but will use more if needed to keep the unicity.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/