Re: [RFC v2] git-multimail: a replacement for post-receive-email

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Feb 13, 2013, 16:12 UTC
Message-ID: <vpqbobo5h2e.fsf@grenoble-inp.fr>
In-Reply-To: <201302131526.57342.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

Show 12 quoted lines

> On Wednesday 13 February 2013 14:56:25 Matthieu Moy wrote:
>> Michael Haggerty <mhagger@alum.mit.edu> writes:
>
>> I think adding a short "dependencies" section in the README (or in an
>> INSTALL file) saying which Python version works could save new users the
>> trouble (I see the sheebang inside the scripts says python2 but since I
>> couldn't use my system's python and called
>> "path/to/python git_multimail.py", this didn't help). Making the script
>> portable with python 2 and 3 would be awesome ;-).
>
> For my 2p worth, I don't like seeing hooks called like this.  Particular those 
> that come as part of the standard installation.

What do you mean by "like this" ?

Show 5 quoted lines

> I call mine by installing little scripts like this (on Debian):
>
>   #!/bin/sh
>   # stored as $GIT_WORK_DIR/.git/hooks/post-receive-email
>   exec /bin/sh /usr/share/git-core/contrib/hooks/post-receive-email

Yes, this is what I was doing (with path/to/python instead of /bin/sh, and git_multimail.py, or more precisely path/to/git_multimail.py, instead of post-receive-email).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/