git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] diffcore-pickaxe: fill_one() doesn't modify textconv

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Apr 4, 2013, 17:05 UTC
Message-ID
<vpqd2uaql8u.fsf@grenoble-inp.fr>
In-Reply-To
<20130404160557.GB25232@ruderich.org>
Simon Ruderich <simon@ruderich.org> writes:
Show 8 quoted lines
> --- a/diffcore-pickaxe.c
> +++ b/diffcore-pickaxe.c
> @@ -75,10 +75,10 @@ static void diffgrep_consume(void *priv, char *line, unsigned long len)
>  }
>  
>  static void fill_one(struct diff_filespec *one,
> -		     mmfile_t *mf, struct userdiff_driver **textconv)
> +		     mmfile_t *mf, struct userdiff_driver *textconv)

Nice, but perhaps you should elaborate a bit more in the commit message to say this is a cleanup without real change.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Simon RuderichNext: Jeff King
Message 2 of 3 in “diffcore-pickaxe: fill_one() doesn't modify textconv”
  1. 2/2 diffcore-pickaxe: fill_one() doesn't modify textconvSimon Ruderich, Apr 4, 2013
  2. Matthieu MoyApr 4, 2013
  3. Jeff KingApr 4, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.