From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Thu, 04 Apr 2013 17:05:53 GMT
Subject: Re: [PATCH 2/2] diffcore-pickaxe: fill_one() doesn't modify textconv
Message-ID: <vpqd2uaql8u.fsf@grenoble-inp.fr>
In-Reply-To: <20130404160557.GB25232@ruderich.org>

Simon Ruderich <simon@ruderich.org> writes:

> --- a/diffcore-pickaxe.c
> +++ b/diffcore-pickaxe.c
> @@ -75,10 +75,10 @@ static void diffgrep_consume(void *priv, char *line, unsigned long len)
>  }
>  
>  static void fill_one(struct diff_filespec *one,
> -		     mmfile_t *mf, struct userdiff_driver **textconv)
> +		     mmfile_t *mf, struct userdiff_driver *textconv)

Nice, but perhaps you should elaborate a bit more in the commit message
to say this is a cleanup without real change.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/