git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 1/2] diff-no-index.c: rename read_directory()

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Mar 19, 2014, 17:47 UTC
Message-ID
<vpqd2hidqsj.fsf@anie.imag.fr>
In-Reply-To
<1395243516-5753-1-git-send-email-mandrei.dinu@gmail.com>
Andrei Dinu <mandrei.dinu@gmail.com> writes:
> Signed-off-by: Andrei Dinu <mandrei.dinu@gmail.com>

The commit message should explain why this is a good change. In general, the "why?" question is more important than the "what" (the reader can see from the patch that you renamed the function, but cannot guess why you did so).

Also, when sending multiple patches, send them as a single thread. See for example:

  http://thread.gmane.org/gmane.comp.version-control.git/244441

In practice, call "git send-email" once, not once per patch. Try sending the patches to yourself first to avoid disturbing the list in case of user error.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Andrei Dinu
Message 2 of 2 in “diff-no-index.c: rename read_directory()”
  1. 1/2 diff-no-index.c: rename read_directory()Andrei Dinu, Mar 19, 2014
  2. Matthieu MoyMar 19, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.