From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Wed, 19 Mar 2014 17:47:08 GMT
Subject: Re: [PATCH v4 1/2] diff-no-index.c: rename read_directory()
Message-ID: <vpqd2hidqsj.fsf@anie.imag.fr>
In-Reply-To: <1395243516-5753-1-git-send-email-mandrei.dinu@gmail.com>

Andrei Dinu <mandrei.dinu@gmail.com> writes:

> Signed-off-by: Andrei Dinu <mandrei.dinu@gmail.com>

The commit message should explain why this is a good change. In general,
the "why?" question is more important than the "what" (the reader can
see from the patch that you renamed the function, but cannot guess why
you did so).

Also, when sending multiple patches, send them as a single thread. See
for example:

  http://thread.gmane.org/gmane.comp.version-control.git/244441

In practice, call "git send-email" once, not once per patch. Try sending
the patches to yourself first to avoid disturbing the list in case of
user error.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/