Re: [PATCH 3/4 v2] Allow detached form (e.g. "git log --grep foo") in log options.
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Jul 28, 2010, 11:29 UTC
- Message-ID
- <vpq8w4vhmkj.fsf@bauges.imag.fr>
- In-Reply-To
- <AANLkTikzL-sgysKD+0CZ100xHWZro=-hDgDgUL2Pb3yw@mail.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> On Wed, Jul 28, 2010 at 09:41, Matthieu Moy <Matthieu.Moy@imag.fr> wrote: > > Here's a better commit message, the subject was >50 chars> (see > Documentation/SubmittingPatches):
I don't see a mention of 50 chars there. Conventions usually limit lines to <80 chars (sometimes 72), and my subject line is 64 chars-wide if you don't count [PATCH], which won't end up in git.git.
Show 9 quoted lines
>> +test_expect_success 'log --grep option parsing' ' >> + echo second >expect && >> + git log -1 --pretty="tformat:%s" --grep sec >actual && >> + test_cmp expect actual && >> + test_must_fail git log -1 --pretty="tformat:%s" --grep >> +' > > There's a lot of behavior change in this series, but only two small > tests that I can see.
4, not 2.
> It would be easy to change the parsing code back without triggering > a regression test.
I've introduced a test for each pattern, but deliberately did not do exhaustive testing: I'm testing the patterns, not the way they are applied. In the same way, I don't think there's a testcase for each use of parse-option in the testsuite.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/