Re: [PATCH 3/4 v2] Allow detached form (e.g. "git log --grep foo") in log options.

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 28, 2010, 10:11 UTC
Message-ID: <AANLkTikzL-sgysKD+0CZ100xHWZro=-hDgDgUL2Pb3yw@mail.gmail.com>
In-Reply-To: <1280310062-16793-3-git-send-email-Matthieu.Moy@imag.fr>

On Wed, Jul 28, 2010 at 09:41, Matthieu Moy <Matthieu.Moy@imag.fr> wrote:

Here's a better commit message, the subject was >50 chars> (see Documentation/SubmittingPatches):

    Subject: git-log: Parse detached options like --grep foo

    Change the option parsing logic in revision.c to accept detached forms
    like `--grep foo' in addition to `--grep=foo'. The rest of git already
    accepted this form, but revision.c still used its own option parsing.

Show 6 quoted lines

> +test_expect_success 'log --grep option parsing' '
> +       echo second >expect &&
> +       git log -1 --pretty="tformat:%s" --grep sec >actual &&
> +       test_cmp expect actual &&
> +       test_must_fail git log -1 --pretty="tformat:%s" --grep
> +'

There's a lot of behavior change in this series, but only two small tests that I can see. It would be easy to change the parsing code back without triggering a regression test.