Re: [PATCH/RFC 1/2] git-rebase -i: Add key word "drop" to remove a commit
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- May 27, 2015, 19:44 UTC
- Message-ID
- <vpq8uc9yfdp.fsf@anie.imag.fr>
- In-Reply-To
- <xmqqsiahltbu.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 9 quoted lines
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes: > >> I find it weird to write >> >> noop <sha1> <title> > > True, but then it can be spelled > > # <sha1> <title>
I do find it weird too. "#" means "comment", which means "do as if it was not there" to me. And in this case it does change the semantics once you activate the safety feature: error out without the "# <sha1> <title>", rebase dropping the commit if the comment is present.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/