Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 27, 2015, 17:41 UTC
Message-ID: <CAPig+cTTDtL+zkjU0iasN2+q=C0P8npEVOuyHBaUN4cFB4ibZQ@mail.gmail.com>
In-Reply-To: <579982712.39028.1432732759119.JavaMail.zimbra@ensimag.grenoble-inp.fr>

On Wed, May 27, 2015 at 9:19 AM, Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> wrote:

Show 14 quoted lines

> Eric Sunshine<sunshine@sunshineco.com> writes:
>> > +       # To uppercase
>> > +       checkLevel=$(echo "$checkLevel" | tr '[:lower:]' '[:upper:]')
>>
>> Is there precedence elsewhere for recognizing uppercase and lowercase
>> variants of config values?
>
> It seems to be commonly used when parsing options in the C files
> through strcasecmp.  For exemple, in config.c:818 :
> if (!strcmp(var, "core.safecrlf")) {
>         if (value && !strcasecmp(value, "warn")) {
>                 [...]
> However we didn't see any precedence in shell files. Do you think we
> should remove it?

Precedence in C code is good enough for me, and it makes sense for your new code to follow suit by being insensitive to case (as you have already done).

However, it would be a good idea to be consistent in your use of uppercase/lowercase in the commit message, documentation, and code, rather than having a mix. I'd suggest sticking with lowercase throughout since lowercase is more commonly used in the codebase (and just easier to read).