git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [bug] .git/hooks/commit-msg.sample test is reversed

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Sep 15, 2015, 09:10 UTC
Message-ID
<vpq8u88cajg.fsf@anie.imag.fr>
In-Reply-To
<55F7DA48.30104@fissore.org>
Federico Fissore <federico@fissore.org> writes:
Show 9 quoted lines
> Hello everyone
>
> In file commit-msg.sample, grep test is reversed. It greps
> '^Signed-off-by: '
> while it should grep
> 'Signed-off-by: '
>
> If you run the sample against attached file, it won't complain. Remove
> the ^ and it will work as expected
I think the test is correct.
In grep, ^ can have two meanings:

'^foo' means "foo at the start of a line" '[^abc]' means "one character but not a, b or c"

The Signed-off-by: trailer is meant to be at the start of a line, hence the ^.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Federico Fissore
Message 2 of 2 in “[bug] .git/hooks/commit-msg.sample test is reversed”
  1. Federico FissoreSep 15, 2015
  2. Matthieu MoySep 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.