[bug] .git/hooks/commit-msg.sample test is reversed

Federico Fissore· Sep 15, 2015, 08:43 UTC · lore

Hello everyone

In file commit-msg.sample, grep test is reversed. It greps '^Signed-off-by: ' while it should grep 'Signed-off-by: '

If you run the sample against attached file, it won't complain. Remove the ^ and it will work as expected

Regards

Federico

    Commit message
    
    Signed-off-by: Me <me@example.com>
    Signed-off-by: Me <me@example.com>

Matthieu Moy· Sep 15, 2015, 09:10 UTC · re: Federico Fissore · lore

Re: [bug] .git/hooks/commit-msg.sample test is reversed

Federico Fissore <federico@fissore.org> writes:

Show 9 quoted lines

> Hello everyone
>
> In file commit-msg.sample, grep test is reversed. It greps
> '^Signed-off-by: '
> while it should grep
> 'Signed-off-by: '
>
> If you run the sample against attached file, it won't complain. Remove
> the ^ and it will work as expected

I think the test is correct.

In grep, ^ can have two meanings:

'^foo' means "foo at the start of a line" '[^abc]' means "one character but not a, b or c"

The Signed-off-by: trailer is meant to be at the start of a line, hence the ^.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/