Re: [PATCH] git-mv: Fix error with multiple sources.

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jan 22, 2010, 07:03 UTC
Message-ID: <vpq7hrapqng.fsf@bauges.imag.fr>
In-Reply-To: <718290.769818367-sendEmail@darysmbp>

"David Rydh" <dary@math.berkeley.edu> writes:

Show 6 quoted lines

>  		if (!is_absolute_path(given_config_file) && prefix)
> -			config_exclusive_filename = prefix_filename(prefix,
> +			config_exclusive_filename = xstrdup(prefix_filename(prefix,
>  								    strlen(prefix),
> -								    argv[2]);
> +									argv[2]));

Broken indentation on the last two lines.

Other than that, you use strdup without free-ing the result. Probably not so serious, but it may be cleaner to actually call free, or to explain why you don't (in commit message).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/