Re: [PATCH] git-mv: Fix error with multiple sources.

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 22, 2010, 06:17 UTC
Message-ID: <7vhbqeacjm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <718290.769818367-sendEmail@darysmbp>

"David Rydh" <dary@math.berkeley.edu> writes:

> This commit also fixed two potentially dangerous uses of
> prefix_filename() -- which returns static storage space -- in
> builtin-config.c and hash-object.c.

This should probably be a separate patch. builtin-hash-object.c also uses prefix_filename() first to obtain vpath without strdup() and then uses the function to create arg, which seems to be unsafe to me. I've looked at all the hits from

    $ git grep -n -e prefix_filename\( -- '*.c'

and other places seem to be Ok.