Re: [PATCH 4/4] bisect: add the terms old/new

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 10, 2015, 08:09 UTC
Message-ID: <vpq7frcast5.fsf@anie.imag.fr>
In-Reply-To: <1839018688.331427.1433920317370.JavaMail.zimbra@ensimag.grenoble-inp.fr>

Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr> writes:

Show 15 quoted lines

> Hi,
>
> thanks for the review, 
>
> (sorry if you received this twice) 
>
> Junio C Hamano <gitster@pobox.com> writes: 
>
>>Just throwing a suggestion. You could perhaps add a new verb to be 
>>used before starting to do anything, e.g. 
>> 
>> $ git bisect terms new old 
>
> Yes it would be nice and should not be hard to implement. But it was not 
> the idea of how the code was made by our elders.

"Somebody else did it like that" is not a good justification. Especially when the previous code was not merged: the code wasn't finished.

But I actually disagree with the fact that it was not the idea. The point of having the terms in BISECT_TERMS was precisely to be generic enough. Had the goal been just to distinguish good/bad and old/new, we would have needed only one bit of information, and encoding it with the existance/non-existance of a file would have been sufficient (as you tried to do in addition to BISECT_TERMS).

> For now we just rebased, corrected and finishing to implement
> functionalities.

functionalities is one thing, but the code should be maintainable to be merged in git.git. Git would not be where it is if Junio was merging patches based on "it works, we'll see if the code is good enough later" kinds of judgments ;-).

Moving from "one hardcoded pair of terms" to "two hardcoded pairs of terms" is a nice feature, but hardly a step in the right direction wrt maintainability.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/