[PATCH 4/4] bisect: add the terms old/new

From: Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>
Date: Jun 10, 2015, 07:11 UTC
Message-ID: <1839018688.331427.1433920317370.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <78277223.323387.1433874176840.JavaMail.zimbra@ensimag.grenoble-inp.fr>

Hi,

thanks for the review,

(sorry if you received this twice)

Junio C Hamano <gitster@pobox.com> writes:

>Just throwing a suggestion. You could perhaps add a new verb to be 
>used before starting to do anything, e.g. 
> 
> $ git bisect terms new old

Yes it would be nice and should not be hard to implement. But it was not the idea of how the code was made by our elders. For now we just rebased, corrected and finishing to implement functionalities.

Show 17 quoted lines

>> * git rev-list --bisect does not treat the revs/bisect/new and 
>> revs/bisect/old-SHA1 files. 
> 
>That shouldn't be hard to add, I would imagine, either by 
> 
> git rev-list --bisect=new,old
> 
>or teaching "git rev-list --bisect" to read the "terms" itself, as a 
>follow-up patch.
> 
>> * git bisect visualize seem to work partially: the tags are 
>> displayed correctly but the tree is not limited to the bisect 
>> section. 
> 
>This is directly related to the lack of "git rev-list --bisect" 
>support, I would imagine. If you make the command read "terms", I 
>suspect that it would solve itself.

It will be corrected in the next patch.

>After reading the previous patches in the series, I expected that 
>this new code would know to read "terms" and does not limit us only 
>to "new" and "old". Somewhat disappointing.

It is still nice and necessary to have new/old as builtin tags but if we have time we will do that.

The others point have been taken in account.