Re: [PATCH v8 01/11] t6302: for-each-ref tests for ref-filter APIs

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jul 8, 2015, 15:46 UTC
Message-ID: <vpq615ud53i.fsf@anie.imag.fr>
In-Reply-To: <CAOLa=ZQ=Mjx-L8Xn9kA86b7nv_bF24Mje1rU-Rmcq4kMqp8qMg@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 21 quoted lines

> On Wed, Jul 8, 2015 at 2:37 PM, Matthieu Moy
> <Matthieu.Moy@grenoble-inp.fr> wrote:
>> Torsten Bögershausen <tboegi@web.de> writes:
>>
>>> Could we have a tweak for people without gpg?
>>
>> I guess we need stg like
>>
>> if ! test_have_prereq GPG; then
>>         skip_all='skipping for-each-ref tests, gpg not available'
>>         test_done
>> fi
>>
>> since we need GPG in the setup test and almost all other tests will rely
>> on it.
>>
>
> Does this need to be there? I see a lot of test files which need GPG, and since
> this test file contains tests which rely on it, without it, it would
> be kinda useless
> anyways?

In many cases, the tests look like

. lib-gpg.sh

test_expect_success 'test that does not use GPG' '
        ...
'

test_expect_success GPG 'test that does use GPG' '
        ...
'

so you can't decide in lib-gpg.sh that you'll skip all tests, because you would skip some tests that could be ran without gpg.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/