git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 01/11] t6302: for-each-ref tests for ref-filter APIs

From
Karthik Nayak <karthik.188@gmail.com>
Date
Jul 9, 2015, 05:52 UTC
Message-ID
<CAOLa=ZS3Sb=OjGFZWykLKctdvoZNy0WCoOfQct--+5W4ck6FYQ@mail.gmail.com>
In-Reply-To
<vpq615ud53i.fsf@anie.imag.fr>

On Wed, Jul 8, 2015 at 9:16 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 39 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> On Wed, Jul 8, 2015 at 2:37 PM, Matthieu Moy
>> <Matthieu.Moy@grenoble-inp.fr> wrote:
>>> Torsten Bögershausen <tboegi@web.de> writes:
>>>
>>>> Could we have a tweak for people without gpg?
>>>
>>> I guess we need stg like
>>>
>>> if ! test_have_prereq GPG; then
>>>         skip_all='skipping for-each-ref tests, gpg not available'
>>>         test_done
>>> fi
>>>
>>> since we need GPG in the setup test and almost all other tests will rely
>>> on it.
>>>
>>
>> Does this need to be there? I see a lot of test files which need GPG, and since
>> this test file contains tests which rely on it, without it, it would
>> be kinda useless
>> anyways?
>
> In many cases, the tests look like
>
> . lib-gpg.sh
>
> test_expect_success 'test that does not use GPG' '
>         ...
> '
>
> test_expect_success GPG 'test that does use GPG' '
>         ...
> '
>
> so you can't decide in lib-gpg.sh that you'll skip all tests, because
> you would skip some tests that could be ran without gpg.
>
Ah! Thanks. Will reply here with your fix included :)
-- 
Regards,
Karthik Nayak
Previous: Matthieu MoyNext: Karthik Nayak
Message 17 of 18 in “add options to for-each-ref”
  1. 00/11 add options to for-each-refKarthik Nayak, Jul 7, 2015
  2. 01/11 t6302: for-each-ref tests for ref-filter APIsKarthik Nayak, Jul 7, 2015
  3. 02/11 tag: libify parse_opt_points_at()Karthik Nayak, Jul 7, 2015
  4. 03/11 ref-filter: implement '--points-at' optionKarthik Nayak, Jul 7, 2015
  5. 04/11 for-each-ref: add '--points-at' optionKarthik Nayak, Jul 7, 2015
  6. 05/11 ref-filter: add parse_opt_merge_filter()Karthik Nayak, Jul 7, 2015
  7. 06/11 ref-filter: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jul 7, 2015
  8. 07/11 for-each-ref: add '--merged' and '--no-merged' optionsKarthik Nayak, Jul 7, 2015
  9. 08/11 parse-option: rename parse_opt_with_commit()Karthik Nayak, Jul 7, 2015
  10. 09/11 parse-options.h: add macros for '--contains' optionKarthik Nayak, Jul 7, 2015
  11. 10/11 ref-filter: implement '--contains' optionKarthik Nayak, Jul 7, 2015
  12. 11/11 for-each-ref: add '--contains' optionKarthik Nayak, Jul 7, 2015
  13. Torsten BögershausenJul 8, 2015
  14. Matthieu MoyJul 8, 2015
  15. Karthik NayakJul 8, 2015
  16. Matthieu MoyJul 8, 2015
  17. Karthik NayakJul 9, 2015
  18. 01/11 t6302: for-each-ref tests for ref-filter APIsKarthik Nayak, Jul 9, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.