Re: [PATCH v8 01/11] t6302: for-each-ref tests for ref-filter APIs
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Jul 9, 2015, 05:52 UTC
- Message-ID
- <CAOLa=ZS3Sb=OjGFZWykLKctdvoZNy0WCoOfQct--+5W4ck6FYQ@mail.gmail.com>
- In-Reply-To
- <vpq615ud53i.fsf@anie.imag.fr>
On Wed, Jul 8, 2015 at 9:16 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
Show 39 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes: > >> On Wed, Jul 8, 2015 at 2:37 PM, Matthieu Moy >> <Matthieu.Moy@grenoble-inp.fr> wrote: >>> Torsten Bögershausen <tboegi@web.de> writes: >>> >>>> Could we have a tweak for people without gpg? >>> >>> I guess we need stg like >>> >>> if ! test_have_prereq GPG; then >>> skip_all='skipping for-each-ref tests, gpg not available' >>> test_done >>> fi >>> >>> since we need GPG in the setup test and almost all other tests will rely >>> on it. >>> >> >> Does this need to be there? I see a lot of test files which need GPG, and since >> this test file contains tests which rely on it, without it, it would >> be kinda useless >> anyways? > > In many cases, the tests look like > > . lib-gpg.sh > > test_expect_success 'test that does not use GPG' ' > ... > ' > > test_expect_success GPG 'test that does use GPG' ' > ... > ' > > so you can't decide in lib-gpg.sh that you'll skip all tests, because > you would skip some tests that could be ran without gpg. >
Ah! Thanks. Will reply here with your fix included :)
-- Regards, Karthik Nayak