Re: Tests with broken && chains in pu

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Apr 4, 2010, 20:15 UTC
Message-ID: <v2yfabb9a1e1004041315x999376f6m7dd689b529ce33d8@mail.gmail.com>
In-Reply-To: <201004042208.58939.j6t@kdbg.org>

Heya,

On Sun, Apr 4, 2010 at 15:08, Johannes Sixt <j6t@kdbg.org> wrote:

> two commits in pu currently add tests with broken && chains:

Show 21 quoted lines

> diff --git a/t/t5800-remote-helpers.sh b/t/t5800-remote-helpers.sh
> index 33f546b..eb31709 100755
> --- a/t/t5800-remote-helpers.sh
> +++ b/t/t5800-remote-helpers.sh
> @@ -9,7 +9,7 @@ test_description='Test remote-helper import and export commands'
>
>  test_expect_success 'setup repository' '
>        git init --bare server/.git &&
> -       git clone server public
> +       git clone server public &&
>        (cd public &&
>         echo content >file &&
>         git add file &&
> @@ -18,7 +18,7 @@ test_expect_success 'setup repository' '
>  '
>
>  test_expect_success 'cloning from local repo' '
> -       git clone "testgit::${PWD}/server" localclone
> +       git clone "testgit::${PWD}/server" localclone &&
>        test_cmp public/file localclone/file
>  '

Thanks for noticing, may I ask how you noticed? Do you have a script or was it manual review?

-- 
Cheers,

Sverre Rabbelier