git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Tests with broken && chains in pu

From
Johannes Sixt <j6t@kdbg.org>
Date
Apr 4, 2010, 20:08 UTC
Message-ID
<201004042208.58939.j6t@kdbg.org>
Junio,
two commits in pu currently add tests with broken && chains:
abbfd017 in cw/ws-indent-with-tab:
diff --git a/t/t4015-diff-whitespace.sh b/t/t4015-diff-whitespace.sh
index 9e57f80..e92eab0 100755
--- a/t/t4015-diff-whitespace.sh
+++ b/t/t4015-diff-whitespace.sh
@@ -354,7 +354,7 @@ test_expect_success 'check tabs and spaces as indentation (indent-with-non-tab:
 
 test_expect_success 'check tabs as indentation (tab-in-indent: off)' '
 
-	git config core.whitespace "-tab-in-indent"
+	git config core.whitespace "-tab-in-indent" &&
 	echo "	foo ();" > x &&
 	git diff --check
 
@@ -378,7 +378,7 @@ test_expect_success 'check tabs and spaces as indentation (tab-in-indent: on)' '
 
 test_expect_success 'check tab-in-indent and indent-with-non-tab conflict' '
 
-	git config core.whitespace "tab-in-indent,indent-with-non-tab"
+	git config core.whitespace "tab-in-indent,indent-with-non-tab" &&
 	echo "foo ();" > x &&
 	test_must_fail git diff --check
 
@@ -386,7 +386,7 @@ test_expect_success 'check tab-in-indent and indent-with-non-tab conflict' '
 
 test_expect_success 'check tab-in-indent excluded from wildcard whitespace attribute' '
 
-	git config --unset core.whitespace
+	git config --unset core.whitespace &&
 	echo "x whitespace" > .gitattributes &&
 	echo "	  foo ();" > x &&
 	git diff --check &&



c8eeb6301 in sr/remote-helper-export

diff --git a/t/t5800-remote-helpers.sh b/t/t5800-remote-helpers.sh
index 33f546b..eb31709 100755
--- a/t/t5800-remote-helpers.sh
+++ b/t/t5800-remote-helpers.sh
@@ -9,7 +9,7 @@ test_description='Test remote-helper import and export commands'
 
 test_expect_success 'setup repository' '
 	git init --bare server/.git &&
-	git clone server public
+	git clone server public &&
 	(cd public &&
 	 echo content >file &&
 	 git add file &&
@@ -18,7 +18,7 @@ test_expect_success 'setup repository' '
 '
 
 test_expect_success 'cloning from local repo' '
-	git clone "testgit::${PWD}/server" localclone
+	git clone "testgit::${PWD}/server" localclone &&
 	test_cmp public/file localclone/file
 '
 
Next: Sverre Rabbelier
Message 1 of 5 in “Tests with broken && chains in pu”
  1. Johannes SixtApr 4, 2010
  2. Sverre RabbelierApr 4, 2010
  3. Johannes SixtApr 4, 2010
  4. Chris WebbApr 4, 2010
  5. Junio C HamanoApr 4, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.