git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH] Add tests for handling of parsing errors in OpenSshConfig

From
Robin Rosenberg <robin.rosenberg@dewire.com>
Date
Sep 25, 2008, 11:33 UTC
Message-ID
<tQAHDMR4.1222342394.9002900.roro@localhost>
In-Reply-To
<20080925083934.GB10273@diku.dk>
Den 9/25/2008, skrev "Jonas Fonseca" <fonseca@diku.dk>:
>Badly quoted entries are now ignored similar to how bad port number are
>currently ignored. A check for negative port numbers is now performed
>so that they also will be ignored.

Nooo. We should really give some feedback on bad entries. OpenSSH (version 5.1) complains and refuses to connect if I give it a bad port number or hostname. It complains about "missing parameter" and bad port number for these cases. OpenSSH doesn't simply ignore them.

HostName=bad" Port=hubba

Even if openssh would ignore them I'd think it would be bad if we did, unless there was some serious compatibility issue here.

-- robin
Previous: Jonas FonsecaNext: Jonas Fonseca
Message 12 of 16 in “Fixed a bug that caused tabs in ~/.ssh/config to break parsing”
  1. Fixed a bug that caused tabs in ~/.ssh/config to break parsingGilion Goudsmit, Sep 20, 2008
  2. Add test for OpenSshConfig separator parsingJonas Fonseca, Sep 20, 2008
  3. Add test for OpenSshConfig separator parsingJonas Fonseca, Sep 20, 2008
  4. Robin RosenbergSep 20, 2008
  5. Jonas FonsecaSep 20, 2008
  6. Test and fix handling of quotes in ~/.ssh/configJonas Fonseca, Sep 21, 2008
  7. Robin RosenbergSep 22, 2008
  8. Shawn O. PearceSep 22, 2008
  9. Jonas FonsecaSep 24, 2008
  10. Shawn O. PearceSep 24, 2008
  11. Add tests for handling of parsing errors in OpenSshConfigJonas Fonseca, Sep 25, 2008
  12. Robin RosenbergSep 25, 2008
  13. Improve handling of parsing errors in OpenSshConfigJonas Fonseca, Sep 25, 2008
  14. Jonas FonsecaSep 25, 2008
  15. Shawn O. PearceSep 25, 2008
  16. Robin RosenbergSep 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.