git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH] Test and fix handling of quotes in ~/.ssh/config

From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date
Sep 25, 2008, 06:26 UTC
Message-ID
<200809250826.59765.robin.rosenberg.lists@dewire.com>
In-Reply-To
<20080924232519.GA15318@diku.dk>
torsdagen den 25 september 2008 01.25.19 skrev Jonas Fonseca:
> Using exceptions seems a bit harsh, since the quote is not really fatal
> in anyway. Also, for badly formatted Port values the value is simply ignored.

For this case OpenSSH complains about a missing parameter. It does not even attempt to look up the host. For malformed port numbers I get "Bad number" (and no attempt to connect. I think an exception is the right way to solve the problem si nce the caller doesn't have to do the error checking. and the error is more obvious to the user. OpenSSH also gives the line number. Maybe we should too. 

The OpenSSH i'm referencing is openssh-5.1p1-1mdv2009.0
-- robin
Previous: Shawn O. Pearce
Message 16 of 16 in “Fixed a bug that caused tabs in ~/.ssh/config to break parsing”
  1. Fixed a bug that caused tabs in ~/.ssh/config to break parsingGilion Goudsmit, Sep 20, 2008
  2. Add test for OpenSshConfig separator parsingJonas Fonseca, Sep 20, 2008
  3. Add test for OpenSshConfig separator parsingJonas Fonseca, Sep 20, 2008
  4. Robin RosenbergSep 20, 2008
  5. Jonas FonsecaSep 20, 2008
  6. Test and fix handling of quotes in ~/.ssh/configJonas Fonseca, Sep 21, 2008
  7. Robin RosenbergSep 22, 2008
  8. Shawn O. PearceSep 22, 2008
  9. Jonas FonsecaSep 24, 2008
  10. Shawn O. PearceSep 24, 2008
  11. Add tests for handling of parsing errors in OpenSshConfigJonas Fonseca, Sep 25, 2008
  12. Robin RosenbergSep 25, 2008
  13. Improve handling of parsing errors in OpenSshConfigJonas Fonseca, Sep 25, 2008
  14. Jonas FonsecaSep 25, 2008
  15. Shawn O. PearceSep 25, 2008
  16. Robin RosenbergSep 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.